CRR0023 - Unnecessary conditional

• Apr 01, 2018

This analyzer detects conditional statements that always evaluate to true because of the conditional statement above. A possible example is shown in the code snippet below.

C#

if(a) {
    if(b) {
        DoSomething();
    }
    else {
        if(a) {
            DoSomethingElse();
        }
    }
}

VB.NET

If a Then
    If b Then
        DoSomething()
    Else
        If a Then
            DoSomethingElse()
        End If
    End If
End If

Consider the flowchart of the code snippet given above.

If you trace the program flow, you will see that the highlighted branch is never reached, which means the conditional statement around the DoSomethingElse function is redundant and can be removed.

C#

if(a) {
    if(b) {
        DoSomething();
    }
    else {
        DoSomethingElse();
    }
}

VB.NET

If a Then
    If b Then
        DoSomething()
    Else
        DoSomethingElse()
    End If
End If