CRR0021 - Subsequent else-if conditions are identical

• Apr 01, 2018

This analyzer detects a conditional statement containing the same conditional statement in its else branch. See the example below.

C#

if (condition) {
    DoSomething();
} 
else if(condition) {
    DoSomethingElse();
}

VB.NET

If condition Then
    DoSomething()
ElseIf condition Then
    DoSomethingElse()
End If

In this code, the DoSomethingElse() function will never be executed because the second condition is checked only if the first condition is false. Since the conditions are similar, the program flow will never reach the body of the second conditional statement. To make it clear, look at the flowchart below on which the highlighted branch will never be reached.

To fix this, remove the second conditional statement from the else branch or change its condition expression so that it differs from the first one.